IBM Mainframe Forum

Hi Experts,

Whenever Code is between 1-20 or 51-70, we are executing some business logic.
My requirement is that, whenever Item 500 with Code 30-40 comes, pass through this same logic.
I tried adding this logic but the problem is that whenever Item is 500 having Code between 1-20, that also gets passed through this business logic which I don't want.
Note: Item 500 only with Code 30-40 should be passed through this logic and other codes for this Item 500 should be bypassing this logic.




Please help.

Thanks
Vinu

add an ( ITEM <not equal> 500 ) to the first two conditions

vinu78, you need to spend more time understanding how COBOL conditionals work. For the OR, if the first part is TRUE then COBOL does not evaluate the second part of the condition. So in your IF statement, if CODE has the value 20 then the first part is evaluated as TRUE and the second and third parts are not evaluated. This is why you are getting the results you see, and why enrico's suggestion will fix your problem.

Thanks Enrico.

Actually the full code is



I just mentioned a part of it for easy understandable scenario. So whether I need to mention ITEM Not equal 500 in the first 4 conditons ?

Thanks
Vinu

might be a little easier to follow and maintain. When mixing AND and OR conditions, use parentheses to make clear the order but don't add parentheses just for the fun of it. The first conditional is AND AND which doesn't need any parentheses to make clear how it will be evaluated.

I feel parentheses and indentation make things clearer.



I do even do that "inner AND". As an AND, as Robert says, it will work exactly without the parentheses, but, and although it won't happen in this example, with a small change to the test, and then the need to change the AND to an OR, things go awry.



Without parentheses that operates as ITEM = 500 and ACODE = 29, OR, entirely separately and on its own, nothing to do with ITEM, ACODE = 41.

Better anyway with 88s.

Here are the data definitions and 88s I invented. Note how the 88s give descriptive power to the code.





Better with one 88 for all four tests in the second part:



Then why not a quiet "nested IF", (or an EVALUATE with two tests).



Of course, I'd have all the "stuff" as a PERFORM (generally).