IBM Mainframe Forum

Hi,

Can anyone please suggest me an optimized code using EVALUATE for the below IF conditions.

IF TSM00-LEGEND-1 = ' ' OR
TSM00-LEGEND-2 = ' ' OR
TSM00-LEGEND-3 = ' ' OR
TSM00-LEGEND-4 = ' ' OR
TSM00-LEGEND-5 = ' '
IF TSM00-COUNTRY-CODE = ' '
IF TSM00-PAYMENT-CODE = ' '
IF TSM00-SUBTYPE = 'VA' OR 'FI' OR 'IM'
MOVE '18000' TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS
ELSE
MOVE '06301' TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS
END-IF
ELSE
IF TSM00-PAYMENT-CODE = 'Y'
MOVE '14000' TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS
ELSE
IF TSM00-PAYMENT-CODE = 'D'
MOVE '17000'
TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS
END-IF
END-IF
END-IF
END-IF
END-IF.

IF TSM00-LEGEND-1 = 'F' OR
TSM00-LEGEND-2 = 'F' OR
TSM00-LEGEND-3 = 'F' OR
TSM00-LEGEND-4 = 'F' OR
TSM00-LEGEND-5 = 'F'
IF TSM00-PAYMENT-CODE = ' '
IF TSM00-COUNTRY-CODE = ' '
MOVE '11001' TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS

ELSE
IF COUNTRY
MOVE '11000' TO FO01-ASSET-CLASS
FO02-CURR-ASSET-CLASS
END-IF
END-IF
END-IF
END-IF.

Optimised in with respect to what? Processing speed, readability, something else?

both Processing speed and readability. Is it possible for us to use EVALUATE instead of IF condition?

well... for readability start using the when You post code

enrico-sorichetti : Sorry i dint get you.

OMG...

both Processing speed and readability. Is it possible for us to use EVALUATE instead of IF condition?

since You expressed the readability concern to <help> Your colleagues to do a their job in a better/less distressing way/environment,
the same concern should be applied also for people helping You on their own time and free of charge

using the code tags areond the code You post ( like I showed You ) will improve readability for people willing to help You !

Hi,
I am not able to paste the screeshot of code, so i ahve attacehd the code screen shot for easy readability. Please check and help me..
Embedded file deleted

here is what I mean by code tags



more readable than screen shots

Here i have attacehd the code so that it will be easy to ready..

Thank you, that is much better.

As far as machine performance is concerned, forget it. Unless you are pushing an enormous number of records through here, you'll not notice a difference either way, although I suspect the IF route would actually come out on top.

So, readability.

Don't use literals. Define items in the Data Division with the values that you need, and give them names which accurately describe those values.

Use 88-levels, again with meaningful names in terms of what that value indicates in the business sense.

If you do those first, you'll find it helps a lot. Then post that and we get to the next step.